Refactoring - Identify and Improve Code Quality Issues in a Given Snippet

Question

## Round 1 - Coding ## Problem You are given the following Python function. Identify all code quality issues and produce a refactored version that is correct, readable, and efficient. ```python # Original code (do NOT modify this block - just analyze it) def process(data): result = [] for i in range(len(data)): if data[i] != None: if data[i] > 0: result.append(data[i] * 2) else: if data[i] < 0: result.append(data[i] * -1) else: result.append(0) else: pass return result ``` Issues to identify: 1. Using `!= None` instead of `is not None` 2. Redundant nested `if` (the `else: if x < 0` branch misses nothing since `x == 0` is handled) 3. `for i in range(len(data))` should be `for x in data` 4. `else: pass` is a no-op 5. Manual abs() logic re-implements `abs()` ```python # Expected refactored version: def process(data: list) -> list: return [abs(x) * (2 if x > 0 else 1) for x in data if x is not None] ``` ## Follow-ups 1. Walk through edge cases: empty list, all-None list, list with zeros. 2. How would you write unit tests to verify the refactored version is behaviorally identical? 3. If `data` is a 10M-element list, what memory concerns does a list comprehension introduce vs. a generator? 4. How does type annotation help catch bugs here before runtime?

Refactoring - Identify and Improve Code Quality Issues in a Given Snippet

Question Details

Full Details

Topics

More from OpenAI